Skip to content

Conversation

@yeonjoon-jung01
Copy link

There is a bug in src/diffusers/utils/peft_utils.py when loading LoRA weights: if an excluded module name is a substring of a target module name, it unintentionally prevents the target module from being loaded.

A simple reproduction example:

import torch
from diffusers import FluxPipeline

pipe = FluxPipeline.from_pretrained("black-forest-labs/FLUX.1-dev", torch_dtype=torch.bfloat16)
pipe.load_lora_weights("Shakker-Labs/FLUX.1-dev-LoRA-AntiBlur", weight_name="FLUX-dev-lora-AntiBlur.safetensors")

This is a known issue, as discussed in:

Although the PEFT library is preparing a fix (see huggingface/peft#2637 (comment)), it's uncertain when that change will be released as part of a stable version. In the meantime, this bug exists in the current main branch of Diffusers and needs to be addressed immediately.

The proposed fix modifies the logic in Diffusers to ensure that exclude_modules are not substring of any target module name, preventing incorrect exclusions. This change may be rolled back in the future once the PEFT-side fix is available and adopted, but until then, it ensures correct and stable behavior for users.

    - Updated the logic in  to use a set for exclude modules, improving efficiency and clarity.
    - Enhanced the filtering process to ensure only relevant modules are excluded based on the target modules set.
@sayakpaul
Copy link
Member

@yeonjoon-jung01 thank you for your contribution but I am afraid I will have to ask you to close the PR as I will open a PR shortly fixing the issue on a deeper level. I hope you will understand and I am sorry about the situation.

@sayakpaul
Copy link
Member

#11999

@sayakpaul
Copy link
Member

Closing the PR in favor of #11999. Thank you for your contributions, though.

@sayakpaul sayakpaul closed this Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants